search

blaise-io / acelink

Play Ace Streams on macOS using Docker.
MIT License
762 stars 49 forks source link

support Colima along with Docker Desktop #49

Closed kakysha closed 2 years ago

blaise-io commented 2 years ago

Hey @kakysha, thanks for contributing!

I don't want to explicitly support Colima because it's supposed to be drop-in and it's still in early development. I would accept a pull request that supports any drop-in container runtime. Can you change this PR a little?

  1. In MainMenu.swift, use canPlay = Process.runCommand("docker").terminationStatus == 0
  2. Same in AppDelegate.application
  3. Revert PATH in Process.runcommand.

Can you confirm Ace Link would still support Colima this way?

kakysha commented 2 years ago

PATH is actually a second improvement to support docker-cli installed via MacPorts, as in my case. I also see some code to start Docker Desktop bundle, what should we do with that in case we have another runtime? I'd opt-in to not touch it as Person who replaced the runtime should know how to start it manually

blaise-io commented 2 years ago

PATH is actually a second improvement to support docker-cli installed via MacPorts, as in my case.

Thanks for the explanation, let's leave that in.

I also see some code to start Docker Desktop bundle, what should we do with that in case we have another runtime? I'd opt-in to not touch it as Person who replaced the runtime should know how to start it manually

I agree.

blaise-io commented 2 years ago

I'll create a new release later this week.

blaise-io commented 2 years ago

And thank you!