blaise-io / acelink

Play Ace Streams on macOS using Docker.
MIT License
747 stars 49 forks source link

refactor: use multistage image approach to reduce size #89

Open ZuBB opened 1 month ago

ZuBB commented 1 month ago

Hello @blaise-io,

I saw that you bumped the image version recently and decided to share the changes I made some time ago finally. I managed to reduce the image size by 15Mb. I hope this change is worth including in mainline

vv@my-precious ~/work/own/acelink/acelink $ docker image ls
REPOSITORY                    TAG       IMAGE ID       CREATED          SIZE
blaiseio/acelink              2.1.0     7a4811d95467   12 minutes ago   328MB
blaiseio/acelink-orig         2.1.0     03f43dd5bd45   9 days ago       343MB
docker/disk-usage-extension   0.2.9     83bc5b217a10   3 months ago     2.82MB
docker/getting-started        latest    289dc403af49   17 months ago    46.5MB
vv@my-precious ~/work/own/acelink/acelink $ 
blaise-io commented 1 month ago

I don't trust apteno/alpine-jq and Alpine is not supported by Acestream, can you base it on ubuntu:focal?

ZuBB commented 1 month ago

I don't trust apteno/alpine-jq and Alpine is not supported by Acestream, can you base it on ubuntu:focal?

apteno/alpine-jq is used for downloading acestream only. Acestream still runs on top of Ubuntu (multistage build). Accordingly to dockerhub this image has been pulled 100M times. Seems like ppl have some trust in it.

Do you still wanna drop it?