blak3r / yaai

SugarCRM Asterisk integration
http://www.sugarforge.org/projects/yaai
GNU General Public License v3.0
81 stars 85 forks source link

Load external JS via https #184

Open tfreier opened 10 years ago

tfreier commented 10 years ago

This is just a small improvement. I noticed Chrome was complaining about this lib because I access my sugar instance via https. I noticed all the other references were already using https links.

blak3r commented 10 years ago

Thanks!

Sent via mobile

On Apr 2, 2014, at 1:29 AM, Till Freier notifications@github.com wrote:

This is just a small improvement. I noticed Chrome was complaining about this lib because I access my sugar instance via https. I noticed all the other references were already using https links.

You can merge this Pull Request by running

git pull https://github.com/tfreier/yaai master Or view, comment on, or merge it at:

https://github.com/blak3r/yaai/pull/184

Commit Summary

load google api JS via https File Changes

M SugarModules/modules/Asterisk/include/AsteriskJS.php (2) Patch Links:

https://github.com/blak3r/yaai/pull/184.patch https://github.com/blak3r/yaai/pull/184.diff — Reply to this email directly or view it on GitHub.

pgorod commented 6 years ago

@tfreier I know you from the SuiteCRM GitHub, and seeing you here on the Callinize site makes me want to ask you if you have this running well with SuiteCRM? Any changes needed?

I don't need this myself, but a user on the Forums is asking about it and I would like to have some integration with Asterisk available for free (even if it is only the basic version of a licensed product). Thanks

umairmalik2410 commented 6 years ago

We're using this base code but had to make changes in order to get this running. Especially if they are using asterisk 13, then more changes would be required.

tfreier commented 6 years ago

@pgorod We used to but only for about a year since it wasn't working well. After that, we wrote our own tool to handle the call integration: https://github.com/tfreier/desktop-crm

However, now we are also not using that anymore. We switched to pipedrive about a year ago. We don't have a call integration there anymore either but the email integration is just so much better.

pgorod commented 6 years ago

Ok, thanks. And sorry to everyone for hijacking this thread! :-)