blake-mealey / mantle

An infrastructure-as-code and deployment tool for Roblox.
https://mantledeploy.vercel.app/
MIT License
85 stars 11 forks source link

Deploying more than 32 products causes Roblox to throttle creation of additional products #126

Open Quenty opened 2 years ago

Quenty commented 2 years ago

Describe the bug Deploying more than 32 products causes Roblox to throttle creation of additional products. This leads to a lot of weird behavior and errors as Roblox hits race conditions and other things.

To Reproduce

  1. Create a new mantle.yml
  2. Put this list of 100 products in https://gist.github.com/Quenty/d729acce94131b512df9b57970072fc1
  3. Run mantle deploy

Expected behavior Upload occurs, if not slowly.

Screenshots Errors occur and we are throttled.

Environment (please complete the following information):

Additional context You can upload at a rate of about 2 seconds safely. There's also another bug I saw which is Roblox would return a 500 error, but still succeed in creating the product.

blake-mealey commented 2 years ago

What would you like to see here? Should Mantle automatically throttle itself to one request every 2 seconds after it has created 32 products?