feat(mantle): support container and instance metadata AWS credential providers

blake-mealey / mantle

An infrastructure-as-code and deployment tool for Roblox.

https://mantledeploy.vercel.app/

MIT License

85 stars 11 forks source link

feat(mantle): support container and instance metadata AWS credential providers #202

Closed TreehouseFalcon closed 9 months ago

TreehouseFalcon commented 9 months ago

This pull adds support for ECS container and EC2 instance metadata credential loading so that keys don't have to be explicitly defined for deployment targets.

Tested in ECS and it works great! Haven't tested with EC2 but it should work the same.

Resolves #201

Side note: Could we get a patch version bump with this update so I can use this change with Aftman instead of using the forked repo?

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mantle-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 7, 2023 4:44pm

blake-mealey commented 9 months ago

Thank you for this contribution! Overall looks good but added a couple comments

TreehouseFalcon commented 9 months ago

Fixed the formatting in the workflow file, testing the environment variable to see if it works on AWS

TreehouseFalcon commented 9 months ago

Never mind, I have to look at this tomorrow. I'm not familiar with Rust so I'm not sure what's up with the compiler errors.