search

blake-regalia / graphy.js

A collection of RDF libraries for JavaScript
https://graphy.link/
ISC License
163 stars 4 forks source link

memory.dataset.fast minus omitting results #59

Closed MikiDi closed 1 year ago

MikiDi commented 1 year ago

Hi,

Thanks for making graphy open source!

We're noticing something odd with memory.dataset.fast's minus-method.
Consider A.minus(B). For cases where set A contains a quad with a subject that occurs in B, but a predicate that doesn't occur in B for that subject, those quads are omitted from the result, where we do expect them.

I couldn't get the whole test suite running, so I wrote a small reproduction with a failing test-set similar to that in the graphy test-suite. You can find it here.

Thanks!

Michaël

MikiDi commented 1 year ago

Hi @blake-regalia , we figure the issue should be situated somewhere around here. Is it the non-empty pairs remainder-part that is supposed to handle the failing case? Any hints? :slightly_smiling_face:

blake-regalia commented 1 year ago

Apologies for the delay. Looking into this now.

blake-regalia commented 1 year ago

Fixed in v4.3.6. Thanks for the details 👍