search

blake-regalia / linked-data.syntaxes

Complete high-res syntaxes for SPARQL 1.1, Turtle, TriG, N-Triples, N-Quads, Notation3 and ShExC
ISC License
30 stars 7 forks source link

Broken with SublimeText 4 ? #25

Closed tfrancart closed 3 years ago

tfrancart commented 3 years ago

Ubuntu recently updated my SublimeText package and LinkedData package is not working anymore. SublimeText build = 4107

Anytthing special I need to do ? Thanks !

tfrancart commented 3 years ago

I think it is the macaron-dark theme that is broken

Here is what I see

image

ncarboni commented 3 years ago

same here, back in ST3 works perfectly

paulwalk commented 3 years ago

I am seeing this problem too. Selecting Preferences / "Color Scheme" / "auto" and then "mariana" seem to be a workaround, but only for the current file. I guess the problem is with the colour scheme.

griffin-rickle commented 3 years ago

Hey all,

TL;DR the LinkedData package is setting the color_scheme and overriding the global color scheme.

One workaround is going to Settings -> Syntax Specific and setting your color scheme there. However, as rwols pointed out in the ST thread, this package should ideally not be setting a Color Scheme at all. Here's the link: https://forum.sublimetext.com/t/syntax-highlighting-broken-in-sublime-text-4/59175/15

blake-regalia commented 3 years ago

The colors being broken in ST4 is actually due to a bug in ST3 that was initially discovered when I opened an issue here and eventually led to this bug report. Unfortunately it is going to require completely redoing the color schemes for it to look right in ST4. We can keep this issue open until such a fix is implemented for ST4.

As for overriding the syntax settings, this was done intentionally because this package creates super specific scopes and requires special color schemes to work properly, for example see this comment.

paulwalk commented 3 years ago

One workaround is going to Settings -> Syntax Specific and setting your color scheme there.

Thanks @griffin-rickle - this is a good workaround.

griffin-rickle commented 3 years ago

@paulwalk The workaround works for now, but the whole point of the package is subverted; i.e. the granularity of highlighting subject, predicate, and object, datatype specifications, strings vs IRIs, etc with a custom color scheme is nowhere near as good as what you get with the color scheme this repo.

@blake-regalia

As for overriding the syntax settings, this was done intentionally because this package creates super specific scopes and requires special color schemes to work properly, for example see this comment.

You are absolutely correct. I attempted to take a look at the code and stop the forcing of a color scheme, but I see this is not the right way to go about it. I would like to help, but unfortunately I'm very new to the world of Sublime Text color scheme definitions and not a JavaScript coder by any means (that doesn't mean I'm not willing to learn). What's the first step to fixing the issue?

blake-regalia commented 3 years ago

Color schemes for ST4 fixed in new release!! v1.0.0 now available for install/update on PackageControl @tfrancart @paulwalk @griffin-rickle @ncarboni

tfrancart commented 3 years ago

Alleluïa, updated ST4 Ubuntu package, and Turtle syntax highlight is back to normal. You made my day !

griffin-rickle commented 3 years ago

Color schemes for ST4 fixed in new release!! v1.0.0 now available for install/update on PackageControl @tfrancart @paulwalk @griffin-rickle @ncarboni

Most excellent. Works perfectly again. Thank you!

paulwalk commented 3 years ago

confirmed - working perfectly now - thanks!

ncarboni commented 3 years ago

works great for me too! Thanks!