search

blake502 / balatro-mobile-maker

Create a mobile Balatro app from your Steam version of Balatro
270 stars 21 forks source link

Import saves from older versions of patch? #23

Closed franzmcfreya closed 3 weeks ago

franzmcfreya commented 1 month ago

I didn't notice the newer version has disabled the option to make the saves accessible and I used it previously on 0.3 beta. Now patching with the latest release, 0.6 the older saves can no longer be used, I don't have root so I can't access both the accessible saves folder and internal folder. Not sure what you guys can do about it I just want to suggest:

  1. leaving the option there for users who already use the former method or
  2. allow the importer to search through the accessible folder(trying to import currently just pulls bunch of empty files.)

Please let me know if anything needs clarification.

blake502 commented 1 month ago

I'll look into this, but unfortunately this one may be written off as "that's beta software for ya" haha. I'll do some testing and see what I can come up with. That said, I think that patch is still in the code-- just commented out. If you're up for compiling it yourself, you can enable that patch again.

franzmcfreya commented 1 month ago

Yeah that's understandable, hope something can be done though. Not sure I'll be able to compile it but I'll definitely take a look at it. Thanks.

fronc commented 1 month ago

I actually used the patch for "Accessible Saves" but am struggling to... Access... them. I am on a non-rooted phone, so is there any way to grab them?

Trying to pull with adb is giving me empty directories, and when I do adb backup com.unofficial.balatro the backup.ab is 1kb and won't open.

franzmcfreya commented 1 month ago

Trying to pull with adb is giving me empty directories, and when I do adb backup com.unofficial.balatro the backup.ab is 1kb and won't open.

Yeah it pulls empty directories because it's trying to get the saves from the internal folder which you of course don't use and hence there's no files to pull. Unfortunately couldn't get around to modifying the patch myself(yet). So I guess we'll just have to wait and see what the devs come up with

blake502 commented 4 weeks ago

I've added the optional command line argument --enable-external-storage-patch to beta-0.7.3

Give it a shot, it should let you keep using the patch formerly known as "accessible saves"

blake502 commented 3 weeks ago

I'll go ahead and close this issue, but I can re-open it if it gives you trouble. Have a great day!

franzmcfreya commented 3 weeks ago

Oh I didn't notice, been busy past few days, I'll try it out, and yeah I guess there's no reason to keep the issue open. Only one question, if I try to pull the saves will it search through that folder as well? If so that'll be awesome as it'd remove the need for that patch. It's fine if it doesn't though it's alright ig. I don't know if you'll see this since it's closed so hope you don't mind CC: @blake502

fronc commented 3 weeks ago

@blake502 how does accessible saves get... "accessed"... for non-root users? Is it possible?

My game is saved using that patch, but I don't have an SD card in my S24 Ultra. Is it possible to still pull the save file?

blake502 commented 3 weeks ago

Oh I didn't notice, been busy past few days, I'll try it out, and yeah I guess there's no reason to keep the issue open. Only one question, if I try to pull the saves will it search through that folder as well? If so that'll be awesome as it'd remove the need for that patch. It's fine if it doesn't though it's alright ig. I don't know if you'll see this since it's closed so hope you don't mind CC: @blake502

At this point, it does not. But that may change.

blake502 commented 3 weeks ago

how does accessible saves get... "accessed"... for non-root users?

The short answer is: "It doesn't"

Check out my comment here https://github.com/blake502/balatro-mobile-maker/issues/43#issuecomment-2067564622 and here https://github.com/blake502/balatro-mobile-maker/issues/29#issuecomment-2054245361

That patch was named speculatively-- and it turns out, it was not any easier to access that location. It should've been named "external storage" patch, but I was optimistic at the time haha.

fronc commented 3 weeks ago

I really appreciate the quick reply, but one follow-up:

You can "access" the folder, but it will appear empty unless you use ADB.

I have access to ADB, just not root. When I try any commands it seems i'm just getting empty files, though. Assuming I used the accessible saves patch, could you tell me what adb commands I should try to extract the save data? Or am I still misunderstanding something critical here (i.e., root is still necessary with ADB)?

Thanks again!