search

blake502 / balatro-mobile-maker

Create a mobile Balatro app from your Steam version of Balatro
270 stars 21 forks source link

External assets of mods not being supported #34

Closed CUexter closed 3 weeks ago

CUexter commented 1 month ago

I tried to install 2 mods but failed. It all involves accessing file that are not lua files. Maybe allow us to use external storage ?

Jojo's Tarot Cards JoJo's Tarots

blake502 commented 1 month ago

Mods are out-of-scope for this project. I'm not even sure if it's possible, given this. Nativefs might not even support Android.

I'm open to exploring this myself at a later point, but there are some more important things I'd like to tackle with the project first.

CUexter commented 1 month ago

i want to know if external storage patch support this but i will try maybe on thursday.

blake502 commented 1 month ago

I'd love to be wrong about this-- But I think that's an oversimplification of how it works.

I haven't looked in to this, mind you, so take this with a grain of salt.. I imagine full mod support would require a patched version of Steamodded that loads all the files from a location that would play nicely with Android.

If you're able to work this out, please let me know what you find. I'm open to making the necessary changes, or merging a PR.

eszoke commented 1 month ago

While it doesn't solve the issue of installing mods on the fly on an existing mobile install, and not sure how LUA mods would work.

But any straight asset replacement mods can still be used by just directly modifying the files in balatro.exe (can change it to .zip) and using that modded exe with the APK/IPA maker.

Got a couple of card and enhancement texture replacements working on both Android and iOS.

blake502 commented 4 weeks ago

So you're saying that the assets can just be packed into the exe, and do not need to be in the mods folder?

If that's the case, I can have Balatro Mobile Maker detect mods during the build process, and offer to automatically pack the assets with the mobile build.

CUexter commented 4 weeks ago

no it only happens to simple texture, one mod of mine allow some sounds to be played when a tarot card is used

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Blake @.> Sent: Saturday, April 20, 2024 1:43:45 PM To: blake502/balatro-mobile-maker @.> Cc: CHAN, Lik Yan Nathan @.>; Author @.> Subject: Re: [blake502/balatro-mobile-maker] External assets of mods not being supported (Issue #34)

So you're saying that the assets can just be packed into the exe, and do not need to be in the mods folder?

If that's the case, I can have Balatro Mobile Maker detect mods during the build process, and offer to automatically pack the assets with the mobile build.

— Reply to this email directly, view it on GitHubhttps://github.com/blake502/balatro-mobile-maker/issues/34#issuecomment-2067566048, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS6TD5EBUHALDLXJK4M5VJ3Y6H6BDAVCNFSM6AAAAABGHC56UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGU3DMMBUHA. You are receiving this because you authored the thread.Message ID: @.***>

CUexter commented 3 weeks ago

i am sorry, but i have fixed the problem, the problem being that mods that have a folder named Assets need to be named assets in ios and android.

which is kinda strange because on linux it works fine as well.

so perhaps the most easy way is to turn any uppercase named folder to lowercase folder

CUexter commented 3 weeks ago

if you want you can close the issue

blake502 commented 3 weeks ago

i am sorry, but i have fixed the problem, the problem being that mods that have a folder named Assets need to be named assets in ios and android.

which is kinda strange because on linux it works fine as well.

so perhaps the most easy way is to turn any uppercase named folder to lowercase folder

Thanks for this info! I'll keep it in mind if we decide to implement official mod support.