search

blakeblackshear / blakeshome-charts

Repo for helm charts
45 stars 58 forks source link

Better probe paths #12

Open ahinko opened 3 years ago

ahinko commented 3 years ago

Hi!

Thanks for all your hard work with Frigate, it's really an awesome project!

I do have one question. Is there a good reason for the hard coded path: / setting on the probes? Doesn't / only return HTML code?

I had an issue (unrelated to Frigate) yesterday that resulted in all my persistent storage to disappear for a short while. But the Frigate pod indicated that everything was fine since the pod kept returning 200 response codes on /.

My Home assistant instance on the other hand was not happy since /api/stats returned a 500. If Frigate would have had better probe configured and the pod would have been restarted everything would have started to work. Now it took me a few hours to realize Frigate wasn't working.

I'm not really sure what a proper health check endpoint should check to determine if Frigate is operational but it seems like /api/stats would be better than / at least.

So, would it be possible to change the path to something else? or at least make the probe paths configurable in the values.yaml file? or is there a reason for keeping / as the path?

blakeblackshear commented 3 years ago

/api/stats or /api/version would be better. This is leftover from before the web UI existed.