search

blakeblackshear / blakeshome-charts

Repo for helm charts
41 stars 52 forks source link

Mount config into `subPath` to support Frigate 0.13 #51

Open benfuu opened 9 months ago

benfuu commented 9 months ago

Since vacuums have been introduced and the path is not configurable, we need to allow another volume to be mounted into /config so that /config/.vaccum can be written to. To do this, we can utilize extraVolumes and extraVolumeMounts but we will need to mount the Frigate configuration into a subPath so that the mountPath does not conflict.

Related PR: https://github.com/blakeblackshear/frigate/pull/6712/files#diff-15e7eac9ac660180d8d6be2ce993db57a3f8aa5d4b2a02333254024b6add7eb4R175

The resulting values file that would be compatible would be:

# values.yaml

extraVolumeMounts:
- name: db
  mountPath: /config

extraVolumes:
- name: db
  persistentVolumeClaim:
    claimName: frigate-db
blakeblackshear commented 7 months ago

The config path is configurable with the CONFIG_FILE environment variable. https://github.com/blakeblackshear/frigate/blob/eed08f534f8887927912211df67255bfeea3d7bd/frigate/app.py#L105

mazay commented 4 months ago

I believe this is outdated, the configmap is already mounted into a subPath and the chart works just fine for 0.13.x