blakeblackshear / blakeshome-charts

Repo for helm charts
41 stars 52 forks source link

Update chart for Frigate v0.13 #58

Closed deosrc closed 5 months ago

deosrc commented 5 months ago

Pulling together code from #9, #44 and #51 to better support Frigate v0.13

The additional configuration needed for full persistence is:

persistence:
  config:
    enabled: true
  media:
    enabled: true

The options for config and media are identical to data. I'd prefer a different name for config to better identify that it is storing the database and other working files, but I'm not sure what that would be. Open to suggestions.

Config has been tested on my local cluster. I haven't yet checked media.

potchin commented 5 months ago

thank you @deosrc! Deployed locally and works fine.

Hopefully this gets merged and stops the endless problems with persistence that everyone has.

k1n6b0b commented 5 months ago

Thank you for this! Wish I had found it before trying to upgrade to 0.13 and (mostly through my own ignorance) breaking things! @blakeblackshear is there someone maintaining this for you as I saw a note you've moved away from k8s in your env? Hugely useful chart IMO, I hope it lives on!

blakeblackshear commented 5 months ago

It's correct that I am no longer using k8s at home. I am happy to merge this, but I would be doing so without any kind of testing.

blakeblackshear commented 5 months ago

@billimek and @onedr0p are collaborators on this repo, but I don't know if they are available to help maintain this chart.

k1n6b0b commented 5 months ago

@billimek and @onedr0p are collaborators on this repo, but I don't know if they are available to help maintain this chart.

Looks like the requester and one other person feel it works, I'm not sure how to switch helm to look at an unmerged PR so I'd say merge it in but that's purely my desire to use 0.13 :)

@potchin @deosrc should this be merged or would further testing be warranted?

deosrc commented 5 months ago

@deosrc should this be merged or would further testing be warranted?

I'm having issues testing the media storage at the moment as my instance isn't able to store clips for longer than 5 minutes. It's an unrelated issue but I wouldn't be comfortable giving it an all clear for GA until I've tested media playback.

thurcombe commented 5 months ago

I've made similar changes to my local deployment recently before checking if a mr existed, hoping this merges in quickly. After updates to the frigate integration in homeassistant, it's broken because it now requires server > 0.12.1

I am confused about the whole PV setup in this project, surely /data is not redundant and is exactly where the database etc should live? /config for config.yml and media for the recordings.. seems sane to me. Instead 0.13 breaks because the db is being moved to /config which is a configmap mount and therefore read only. This setup isn't intuitive, is there some reason for this layout?

blakeblackshear commented 5 months ago

This setup isn't intuitive, is there some reason for this layout?

Yes. This follows an approach consistent with Home Assistant. There is no /data volume for addons in HA. The default approach supports running as an addon because a large portion of the userbase runs Frigate that way. Future versions will continue to expand on editing the config directly in the UI which will write back to the yaml config, but you will always be able to just mount a read only yaml config if desired. Both the config and the database locations can be easily customized in Frigate if you prefer to do something different.

newbenji commented 5 months ago

Hope it soons get merged in