helm chart service update to expose webrtc 8555 - Githubissues

blakeblackshear / blakeshome-charts

Repo for helm charts

41 stars 52 forks source link

helm chart service update to expose webrtc 8555 #59

Open k1n6b0b opened 5 months ago

k1n6b0b commented 5 months ago

webrtc will use port 8555 (TCP/UDP) for connections

This chart needs webrtc TCP and UDP exposed by the service like RTSP was exposed in this PR https://github.com/blakeblackshear/blakeshome-charts/pull/53/commits/6d096123ae1ce1783eba660c751054f33fc99295

I added this manually to my service

 - name: webrtc-tcp
   protocol: TCP
   port: 8555
   targetPort: 8555
 - name: webrtc-udp
   protocol: UDP
   port: 8555
   targetPort: 8555

If thats correct i could try writing a PR but I'm not too familiar with the process. @mazay that was your PR what do you think about webrtc?

mazay commented 5 months ago

I'm not using webrtc but I guess it makes sense to implement this. I think you can submit a PR and wait for approvals, mine was approved within a few days. :)