search

blakeblackshear / frigate-hass-addons

Frigate hass.io addons
MIT License
250 stars 133 forks source link

allow https in frigate-proxy configuration #112

Open toxic0berliner opened 1 year ago

toxic0berliner commented 1 year ago

as I read it in https://github.com/blakeblackshear/frigate-hass-addons/blob/main/frigate_proxy/config.yaml I believe the http scheme is hardcoded for the frigate_proxy addon. I would realy benefit from being able to use https instead. could we make this a variable ?

Clarifying why : I run frigate on a synology NAS that comes with a docker version that does strange NAT and keeps me from securing frigate based on the source IP address of the client. But if I can use https I can use my haproxy on my firewall that magically solves the source IP issue but trafic should realy be encrypted on this path so https would be realy nice ! Note that I do have valid cert by letsencrypt and such so should't be an issue of trust.

antonjs commented 1 year ago

I just submitted a pull request adding this functionality. In the mean time, if you want to test out my solution, you can add https://github.com/antonjs/frigate-hass-addons-antonjs as a repository and try my forked version which adds SSL support.

toxic0berliner commented 1 year ago

Thanks a lot @antonjs !!! afk for a few days but will definitely try this out !

I see you've added an option to pass the proper host even if using traefik, nice, thanks !

If I can comment, I'd probably have added an option to enforece or disable vrification of the https certificate (yes, https with a self-signed cert is sometimes still better than http :D ), and possibly give it the proper CA to trust to accept the cert. Actually very curious of how you could do this, I always had quite a bit of trouble to make it happen inside docker containers :D