Closed NickM-27 closed 1 month ago
@NickM-27
i think its because for some reason the /review/<id>/preview.gif
endpoint is missing the .gif part on the main Frigate repo:
if i remove .gif
from your code above it works
@kirsch33 the tests here have no knowledge of frigate code. Them failing is not directly related to it actually working in frigate or not
understood, regardless when I implemented this on my own it was not working without removing .gif
so just wanted to mention it
yeah this PR is outdated since I implemented it
@dermotduffy can you take a look at this if you have a minute? I am at a loss as to why 500 is occurring when it works in actual usage
@NickM-27 Had a shot. Note that I don't know what the real backend paths are, so you'll have to sanity check/edit my changes.
PS: You may kick yourself :-)
I see vs code wasn't warning me of my silly mistake. 😂
@NickM-27 LGTM. I think we probably want this on dev
?
Oops yep, updated
Might need some help with this, works on my live instance but for some reason it says that it doesn't work here