blakeblackshear / frigate-hass-integration

Frigate integration for Home Assistant
MIT License
657 stars 110 forks source link

Support proxy view for preview gifs #664

Closed NickM-27 closed 1 month ago

NickM-27 commented 2 months ago

Might need some help with this, works on my live instance but for some reason it says that it doesn't work here

kirsch33 commented 2 months ago

@NickM-27 i think its because for some reason the /review/<id>/preview.gif endpoint is missing the .gif part on the main Frigate repo:

https://github.com/blakeblackshear/frigate/blob/2e639415987ca3eb546aed842f06eef691636d8e/frigate/api/media.py#L1336

if i remove .gif from your code above it works

NickM-27 commented 2 months ago

@kirsch33 the tests here have no knowledge of frigate code. Them failing is not directly related to it actually working in frigate or not

kirsch33 commented 2 months ago

understood, regardless when I implemented this on my own it was not working without removing .gif so just wanted to mention it

NickM-27 commented 2 months ago

yeah this PR is outdated since I implemented it

NickM-27 commented 1 month ago

@dermotduffy can you take a look at this if you have a minute? I am at a loss as to why 500 is occurring when it works in actual usage

dermotduffy commented 1 month ago

@NickM-27 Had a shot. Note that I don't know what the real backend paths are, so you'll have to sanity check/edit my changes.

PS: You may kick yourself :-)

NickM-27 commented 1 month ago

I see vs code wasn't warning me of my silly mistake. 😂

dermotduffy commented 1 month ago

@NickM-27 LGTM. I think we probably want this on dev?

NickM-27 commented 1 month ago

Oops yep, updated