search

blakeembrey / free-style

Make CSS easier and more maintainable by using JavaScript
MIT License
707 stars 29 forks source link

Refactor implementation #32

Closed blakeembrey closed 8 years ago

blakeembrey commented 8 years ago

Closes https://github.com/blakeembrey/free-style/issues/30.

/cc @basarat @ajoslin @jkroso @carloslfu

I killed a few of the "utilities" in use sporadically because there's a lot of viable and better written third-party alternatives (classnames, image-url and insert-css). The library itself has been a simplified as a result, and is under 500 lines in total. Anyone using the change events should also now check changeId to figure out if an update is required. How do these changes sound to everyone (and anyone else watching the repo)?

blakeembrey commented 8 years ago

@carloslfu I forgot to mention in the summary, but the de-duping feature actually still works when prefixes are enabled because of the way the library is written. You just end up with multiple class name selectors on the one style - you can check the test for more info.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 98.76% when pulling ef5b96878142d04e30c3ff8a55cc5e8afa693122 on 2.0 into 09ad78cded3eddbd9ba909093ce3bdc0a4850e1b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 98.76% when pulling c49c1ef37c20e6678a5f45a5aa475c5e1359ad62 on 2.0 into 6a18fef47c802e295bcc800c31d2f46a4678457a on master.