blakeembrey / free-style

Make CSS easier and more maintainable by using JavaScript
MIT License
707 stars 29 forks source link

Added new version of i-css #64

Closed roman-orlovskiy closed 7 years ago

roman-orlovskiy commented 7 years ago

Hello, i updated my module with some your remarks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.168% when pulling c9c959df96334016eae92847c783288f3f1b19e5 on irom-io:patch-1 into b527f3c55a2b8d2bc6e3fe7ce08e60b7b7c4d0d8 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 98.195% when pulling c0242c8b4f316cbadeb4816957f547afaf898809 on irom-io:patch-1 into b527f3c55a2b8d2bc6e3fe7ce08e60b7b7c4d0d8 on blakeembrey:master.

blakeembrey commented 7 years ago

Sorry for the delay, took a holiday and spent some extra time on break. Unfortunately there's still 2000 more issues for me to tackle, but I'm getting back slowly 😄

I fixed up the grammar slightly and will merge. Just a note though, you could have just updated the previous PR and pinged me - there's no need to open more than one PR per feature/issue. From the other thread (https://github.com/blakeembrey/free-style/pull/59):

As an aside, there's a more performant way to change styles now too - you can use "change" events from free-style to interact directly with a style sheet instance. Check out https://github.com/blakeembrey/react-free-style/blob/2aebdc92baa6193820b547d292b690ec5ab751f6/src/react-free-style.ts#L51-L60 to get an idea of how that would work.