search

blakeembrey / javascript-stringify

Stringify is to `eval` as `JSON.stringify` is to `JSON.parse`
MIT License
140 stars 16 forks source link

Support for async function? #23

Closed IniZio closed 5 years ago

IniZio commented 5 years ago

Hi many thanks for authoring this library, honestly never thought it is possible to stringify js code before. :)

I noticed that this library does not support async functions, which is supported in nodejs LTS currently.

I might try to work out a PR if such enhancement is suitable, though I do not fully understand the logic yet so it might need some time to figure out.

blakeembrey commented 5 years ago

@IniZio I believe this is covered by https://github.com/blakeembrey/javascript-stringify/pull/22, but it's a complex change so I haven't landed it yet. Give me a few weeks and it'll be in a 2.0 release.

IniZio commented 5 years ago

Yea I also noticed that, just making a custom package for my own usage for now,looking forward to that release :)

IniZio commented 5 years ago

I am closing this since the rewrite has been merged. thanks for the library :)