blakeembrey / javascript-stringify

Stringify is to `eval` as `JSON.stringify` is to `JSON.parse`
MIT License
140 stars 16 forks source link

Handle Error objects #9

Closed zalmoxisus closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.17% when pulling 0df949271404e548d88aec5f4d9f2a5cbf7a7029 on zalmoxisus:error into ecba78dca1c567a291e353ba0c6cbe6f41965e14 on blakeembrey:master.

zalmoxisus commented 7 years ago

@blakeembrey, what if we'll omit new where's not mandatory? For having data inspection simpler. Basically, for Error, Boolean, String and Number. As we already don't add new for Symbol.

UPDATE: I see you're using primitives for Boolean, String and Number. Will skip it only for Error then.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.17% when pulling 943b4e7bc2251ca1329c62e8b10e1d2e3c187d1f on zalmoxisus:error into ecba78dca1c567a291e353ba0c6cbe6f41965e14 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.167% when pulling ed8c1dadaa4e03574a54d8c871dbc48e15d36e74 on zalmoxisus:error into ecba78dca1c567a291e353ba0c6cbe6f41965e14 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.167% when pulling ed8c1dadaa4e03574a54d8c871dbc48e15d36e74 on zalmoxisus:error into ecba78dca1c567a291e353ba0c6cbe6f41965e14 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.167% when pulling 0b1c42ecc95376fca2ab7558197167edfe14791d on zalmoxisus:error into ecba78dca1c567a291e353ba0c6cbe6f41965e14 on blakeembrey:master.