search

blakeembrey / metalsmith-pagination

A Metalsmith plugin for paginating arrays and collections
MIT License
34 stars 10 forks source link

Fixes #19 - path option arguments don't work correctly #23

Closed chebum closed 6 years ago

chebum commented 8 years ago

Hi,

I changed the templating syntax to {num} as you suggested. I changed readme and tests as well. I decided not to add a string-templates dependency because the change is just two characters long.

Thanks,

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9bc4c3c97d4d616b5f90dc4f17a68e3830828c81 on chebum:master into e6cdeb5aeae4296b6fd08227f3b1c7ffdc6fe5d4 on blakeembrey:master.

blakeembrey commented 8 years ago

I would prefer that the dependency is used for consistency. I don't like the iterating and replacing with a custom regexp each time, it's not particularly performant and theoretically can end up with you replacing the same inserted string a number of times.