search

blakeembrey / tslint-config-standard

A TSLint config for JavaScript Standard Style
Other
358 stars 43 forks source link

Code that errors indentation when upgrading from v4 to v7 #46

Closed quantuminformation closed 6 years ago

quantuminformation commented 6 years ago

I don't think this indentation error is correct, I didn't get it before

screen shot 2018-05-22 at 07 32 05

line 319 looks fine to me.

When rolling back to "tslint-config-standard": "^4.0.0" it works fine.

blakeembrey commented 6 years ago

When opening an issue, considering copy and pasting the code you have issues with instead of taking a screenshot. People won't be able to correct your issue otherwise, since it's unfair to force someone to go to the effort to recreating the code.

In any case, it looks correct to me. A major version means a breaking change and your indentation looks incorrect - you have a four space indent below line 312 and the closing parenthesis doesn't align on line 329.