search

blakeembrey / tslint-config-standard

A TSLint config for JavaScript Standard Style
Other
358 stars 43 forks source link

no-unused-variable is deprecated #51

Closed LinusU closed 6 years ago

LinusU commented 6 years ago

no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.

Should we just disable the rule?

Personally, I'm not a fan of moving lint checks into the compiler, I think... Oh well 🤷‍♂️

blakeembrey commented 6 years ago

Me either. I think this was already fixed though, just needs to be released. Will follow up over the weekend.

LinusU commented 6 years ago

Yeah, looks like it was fixed here: 1a99e55bbe24553331fa78b8c088f9cb0b06f113

ghost commented 6 years ago

@blakeembrey : can you publish a new release?

ghost commented 6 years ago

@blakeembrey : hmm maybe it might be wise to support typescript 3.x too, but i'm not sure when tslint will publish their 3.x support though.

blakeembrey commented 6 years ago

Is this somewhat urgent for you? As far as I understand it’s a deprecation, is it breaking something?

ghost commented 6 years ago

If there were no other changes coming soon then I would want the release. In this case though, might as well wait for a typescript 3.x compatible tslint.

boycce commented 6 years ago

Any chance we publish a new release, linting deprecation notices are a pain in Sublime.

ghost commented 6 years ago

It'd be nice to see https://github.com/blakeembrey/tslint-config-standard/pull/53 added before a new release is cut.

adrianhopebailie commented 6 years ago

Minor changes are what npm patch releases are for. A quick patch (v7.1.1) that includes 1a99e55 would be great

blakeembrey commented 6 years ago

This would be a major release, not a patch. It’s removing a feature.

Pilatch commented 6 years ago

I, too, am distracted by my linter yelling at me each time I open my text editor and point it at a TS file.

It burns my biscuits, but does not fry my loins. Therefore I will wait for 8.