search

blakej115 / magic-forms

Create easy (and almost magic) AJAX forms
https://octobercms.com/plugin/blakejones-magicforms
MIT License
7 stars 4 forks source link

Remove the use of inline-errors.js + convert JS to vanilla #10

Open PubliAlex opened 1 year ago

PubliAlex commented 1 year ago

Hello,

First, thank you to take the lead to maintain the excellent magic form plugin for the october community.

As one of your plugin goal is to make it compatible with october cms 3, you should make some changes about javascript.

Remove inline-errors.js file This is the role of the theme, and not a plugin to handle form errors, even if converted to vanilla js, the used classes are heavily opiniated to an old version of bootstrap, it should be removed.

Concert others scripts to vanilla js As jquery is not needed anymore with october 3, you should convert all other JS to vanilla JS.

Best regards,

blakej115 commented 1 year ago

I am currently considering options for major upgrades to the Magic Forms plugin (or creating a spiritual successor).

Thanks!