Replace querystring with URLSearchParams

blakejoy / tmdb-ts

Typescript client wrapper for TheMovieDB (TMDB) v3

MIT License

37 stars 12 forks source link

Closed Hoidi closed 1 year ago

Hoidi commented 1 year ago

Resolves #13

Some things I would appreciate feedback on. Other feedback is ofcourse welcome

Naming for the new interfaces PageOptions and LocaleOptions. Not the greatest names but they made it easier to work with URLSearchParams
Lots of code checking if the options is undefined. Should I create a new utils function for this logic?
Should I bump the version to 0.1.5?

blakejoy commented 1 year ago

I'm down for making this change since it seems like the use case extends further than just server side utilizing this lib

Der-Penz commented 1 year ago

I think this can be merged now.

blakejoy commented 1 year ago

bump the version and we can get this merged @Hoidi