blakejoy / tmdb-ts

Typescript client wrapper for TheMovieDB (TMDB) v3
MIT License
37 stars 12 forks source link

feat - add linting and prettier #22

Closed blakejoy closed 1 year ago

blakejoy commented 1 year ago

Fix/Add different linting rules and added prettier for formatting.

Hoidi commented 1 year ago

Seems to be working ๐Ÿ‘

However, I get lineending diffs on all files when running the fotmat command. Is this because I'm on windows and it does some weird stuff or did you forget to run it one last time?

blakejoy commented 1 year ago

Seems to be working ๐Ÿ‘

However, I get lineending diffs on all files when running the fotmat command. Is this because I'm on windows and it does some weird stuff or did you forget to run it one last time?

Hmmm yeah Iโ€™m on Mac I think itโ€™s checking for just LF. I believe Windows uses CR/CR+LF. Let me see if I can make it more exclusive.

blakejoy commented 1 year ago

Does lint:fix resolve the issue or does the ide complain still ?

Hoidi commented 1 year ago

It's git that complains, not the ide. And running lint:fix doesn't fix it.

Should the .prettierrc still contain "endOfLine": "lf" if you want to rurn off linebreak rules?

blakejoy commented 1 year ago

It's git that complains, not the ide. And running lint:fix doesn't fix it.

Should the .prettierrc still contain "endOfLine": "lf" if you want to rurn off linebreak rules?

Ahh so this is coming from git.. is it an actual error or a warning?

Hoidi commented 1 year ago

It's a warning warning: in the working copy of 'src/endpoints/account.ts', LF will be replaced by CRLF the next time Git touches it

Der-Penz commented 1 year ago

Is adding husky in consideration?

blakejoy commented 1 year ago

Is adding husky in consideration?

It's added.