search

blakejoy / tmdb-ts

Typescript client wrapper for TheMovieDB (TMDB) v3
MIT License
40 stars 13 forks source link

[i18n]Fixed all implemented methods that should allow LanguageOptions to be passed #42

Closed jeremyVignelles closed 9 months ago

jeremyVignelles commented 12 months ago

Everywhere the API expects a language option, I updated the parameters so that they match the expected API options.

Fixes #39

NOTE: I tried to make no breaking changes, but there was a bad options typing in methods TvShowEndpoint/{airingToday,popular,topRated} : The RegionOption was included here by mistake.

This is technically a breaking change for codes that incorrecly use the API

reaver585 commented 11 months ago

@blakejoy any chance this PR could be merged some time soon?

blakejoy commented 11 months ago

I can take a look today/tomorrow

reaver585 commented 11 months ago

Thanks a ton.

blakejoy commented 11 months ago

Few comments @jeremyVignelles

jeremyVignelles commented 10 months ago

@blakejoy : rebased and moved the interface as requested. I also added the language option on the recently added tv-shows/aggregateCredits method.

Let me know if you need something else

jeremyVignelles commented 10 months ago

@blakejoy : up 🙂

johann-taberlet commented 10 months ago

I also really need this critical filter.😊

blakejoy commented 10 months ago

I’ll take a look at this today 😎

jeremyVignelles commented 9 months ago

Did you have time to review yet ? any comments left ?

blakejoy commented 9 months ago

Merged