blakejoy / tmdb-ts

Typescript client wrapper for TheMovieDB (TMDB) v3
MIT License
39 stars 12 forks source link

Add people endpoint #6

Closed Der-Penz closed 1 year ago

Der-Penz commented 1 year ago

People endpoint!

I added support for the people endpoints. All HTTP Get requests for the people TMDB endpoint are supported.

Additions

blakejoy commented 1 year ago

Great work on the refactor and addition of this endpoint! I think since this introduces some changes to the types it may break some of the current implementations. I would be down to bump this to a major version to reduce that.

Der-Penz commented 1 year ago

I am trying to add the currently missing endpoints in the near future. The old ones should be tested if they are still up to date.

blakejoy commented 1 year ago

I am trying to add the currently missing endpoints in the near future. The old ones should be tested if they are still up to date.

Yup understand that but the new addition on PaginatedResult type would cause a breaking change for anyone pulling in the latest minor/patch version. If you want to, you can add the people endpoint and in a subsequent request update the types.

Der-Penz commented 1 year ago

Ok I am going to rewrite the endpoint to use the basic people endpoint and make a seperate pull request with the PaginatedResult

blakejoy commented 1 year ago

Ok I am going to rewrite the endpoint to use the basic people endpoint and make a seperate pull request with the PaginatedResult

Sounds like a plan 👍