blakelead / couchbase_exporter

Export metrics from Couchbase Server for Prometheus consumption
Other
35 stars 18 forks source link

Do not force installing exporters on each node in cluster #50

Open nemmyam opened 4 years ago

nemmyam commented 4 years ago

I have read your answer to @shipmak in his issue #6 and I read the prometheus Deployment paragraph but I think this should be an exception here. It looks as if the exporter is meant to be running from each node in the couchbase cluster but in our case we have a 6 nodes cluster (others might have more) but I'm running the exporter as a deployment in a separate kubernetes cluster. I don't think in my case it makes sense to have 6 deployments running only with different nodes variables, plus the redundant "Bucket" metrics DO mess up your queries ones you start sum up things and forget about splitting by the "instance" label.. I feel like the best solution for this is a "self discover" mechanism for each node in the cluster and report them all as a label. For example instead of: cb_node_service_up 1 => cb_node_service_up {node="node1"} 1 cb_node_service_up {node="node2"} 1

Also, in the grafana dashboard that you provided (nice work btw!) the $node variable assumes the same idea of the exporter running from couchbase node itself when in fact the "instance" label is just the kubernetes node the exporter is running in.

blakelead commented 4 years ago

Hi @nemmyam, thank you for you insight!

You convinced me :D I'll add this task to my backlog and work on it asap.

But please understand that since Couchbase has released an official exporter, I'm not as committed to this project as I was before so it may take me some time.

ashish235 commented 4 years ago

Hi @blakelead , are you still planning to provide this feature please? I am more interested in using your exporter rather than the official one.

pierreyvesv commented 3 years ago

Hi @blacklead, I didn't manage to build the official one, and no binary is provided. Tried yours and it worked out of the box .