search

blakelee / CoinProfits

Keep track of your cryptocurrency with this portfolio manager. Made in native Android to offer you the best user experience.
MIT License
4 stars 1 forks source link

Memory leak + App crash #2

Open AKprisonER opened 7 years ago

AKprisonER commented 7 years ago

Well it happened on emulator and real device too

blakelee commented 7 years ago

I fixed the app crash. Not sure about the memory leak. I've seen the leak app pop up a few times but it hasn't actually reported any leaks for me.

AKprisonER commented 7 years ago

i think its due to storage permissions it seems

AKprisonER commented 7 years ago

capture using canaryleak...it dosent show any leaks in its screen. Its just keeps showing and memory dump occuring hgf

blakelee commented 7 years ago

Did the new commit fix the crashes for you? Rc1 of lifecycle components broke support with rxlifecycle so rxlifecycle needs to be updated.

That's what's been happening with me. No leaks yet it still pops up. I think it's due to rxlifecycle.

AKprisonER commented 7 years ago

Memory leak is happening due to FinalizerReference it seems

  1. Coinprofits.model 2.Coinprofits,fragment

    And finally,i came to a conclusion that kotlin is still not perfect for android apps

blakelee commented 7 years ago

Stack overflow seems to not have a lot of information about it. Since you said it's in a fragment I have an idea where to look.

The overview fragment doesn't have any separation. I need to restructure it to mvvm. Once it has some better architecture, maybe the issue will solve itself.

I'm pretty happy with using kotlin so far. Just takes a bit to get used to

AKprisonER commented 6 years ago

How to add multi currency ? As i am out of USD, like choose display currency from Euro or Krw or Inr

blakelee commented 6 years ago

I setup the db so that eventually I could add differing currencies. Coinmarketcap has api calls for different ones. However, the map api only allowed for usd. I'm not sure how I wanted to implement it. I was thinking of having usd be the base and having a multiplier for the other currencies

AKprisonER commented 6 years ago

Any implementation of other currencies