Plunder

[markbrockettrobson]

WIP , traits are not selected by the randomizer, IDK why yet will look again tomorrow

[gillesgros]

in cards.ts

  static getAllTraits(cards: Card[]): Trait[] {
    return Cards.getCardsOfType<Ally>(cards, Trait);
  }

should be

  static getAllTraits(cards: Card[]): Trait[] {
    return Cards.getCardsOfType<Trait>(cards, Trait);
  }

[markbrockettrobson]

OK ready to Review @gillesgros

Thanks in advance

[gillesgros]

On the randomizer page, when Traits are selected the title remains "Events" or "Events & Ways" it should be more specific

On the recommended kingdoms page, on a set when Trait and Event are selected display is ok, when just trait it is not so fine.

[gillesgros]

When reloading page on recommended kigndoms, it switch back to Dominion 1st Ed. May be is was the same before. I need to check.

[markbrockettrobson]

When reloading page on recommended kigndoms, it switch back to Dominion 1st Ed. May be is was the same before. I need to check.

I think we can leave that for an issue

[markbrockettrobson]

On the randomizer page, when Traits are selected the title remains "Events" or "Events & Ways" it should be more specific On the recommended kingdoms page, on a set when Trait and Event are selected display is ok, when just trait it is not so fine.

on it

[gillesgros]

Hello, do you need help to publish your work ?

[markbrockettrobson]

Sorry just finding time has been hard feel free to push it over the line

[markbrockettrobson]

How about I merge it as is and dress the feedback when I have time in a new PR

[gillesgros]

Sound good to me

[gillesgros]

You need to deploy it. Tell me if you need me to do it

[markbrockettrobson]

just rand the cicd deployment on the latest master https://github.com/blakevanlan/KingdomCreator/actions/runs/4107968607

no luck, how do you deploy this project ?

[gillesgros]

You need to buy the project. push it on git and then run the CICD framework