PR Merging multiple changes + translation

blakevanlan / KingdomCreator

Deck randomizer for Dominion

MIT License

44 stars 31 forks source link

PR Merging multiple changes + translation #148

Closed gillesgros closed 1 year ago

gillesgros commented 1 year ago

PR # 136 - Polish language support

PR # 141 - added German translation for RandomizerSidebar
PR # 147 - fix encoding errors
I #51 - Query parameters aren't cleaned up
I #128 - Bane card present without Young Witch in the kingdom
I # 67 - Landmarks aren't generated if the query parameters have supply cards

gillesgros commented 1 year ago

If you have no time, let me know.

markbrockettrobson commented 1 year ago

sorry time has been hard to , I will try this weekend but ping me if I dont get back to you by Monday

gillesgros commented 1 year ago

Any time to look into it ? or should I move forward ?

markbrockettrobson commented 1 year ago

ya sorry cant find the time , just move forward sorry

doc4q commented 1 year ago

Hey guys, I'm cheerfully waiting for the Polish translation (#136) to be merged. Can I help out? Working with TS everyday and worked with Vue as well before.

gillesgros commented 1 year ago

Adding features and translations. Need to migrate ti vue 3 and vite.js ?

doc4q commented 1 year ago

Thank you for merging @gillesgros! I can really recommend to use Vite for Vue web apps. Let me know if I can help with the migration (or assign me to an issue).

gillesgros commented 1 year ago

Hello 9tmark,

I am on the migration path to vue 3 and vite (see my repos). Vue 3 seems OK, but still struggling with vite and its subtleties.