blambo / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Attempt to re-edit the same blip causes shiny #189

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.Open Wiab
2.Click on some blip and then on "Edit" to enter edit mode.
3.Click again to leave edit mode.
4.Click again on Edit to re-enter edit mode

What is the expected output? What do you see instead?
Expected: to enter edit mode. Actually: Shiny

Exception attached.

What changeset or version are you using? On what operating system?
Revision: 3e817f198f

Please provide any additional information below.
None

Original issue reported on code.google.com by vega113 on 22 Dec 2010 at 7:03

Attachments:

GoogleCodeExporter commented 8 years ago
If i comment the lines 1425-1426 in ContentDocument i.e.
Preconditions.checkState(level != Level.EDITING,
        "Cannot attach editor to a document already with an editor");
It seems to work normal.

Original comment by vega113 on 22 Dec 2010 at 7:33

GoogleCodeExporter commented 8 years ago
Verified

Original comment by ano...@google.com on 23 Dec 2010 at 12:45

GoogleCodeExporter commented 8 years ago
(I'm not working on this right now, leaving it assigned to me)

Original comment by danila...@google.com on 23 Dec 2010 at 1:00

GoogleCodeExporter commented 8 years ago
I'll take this.

Original comment by hearn...@google.com on 7 Jan 2011 at 8:19

GoogleCodeExporter commented 8 years ago
Fixed by patch 43328221f89a

Original comment by hearn...@google.com on 10 Jan 2011 at 5:40