blambo / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Make the base url of the WIAB configurable #207

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Attached a patch to make the base URL of WIAB configurable (as we talked 
yesterday in the office hours).

The goal is to permit something like:
http://127.0.0.1:9898/otherdir/
where <otherdir> it configurable via the server.config file.

The attached patch it's a work in progress. Now the login/register gxp pages 
are working (with "/" or "/otherdir/" as base url) and the servlets are 
listening to the configurable URLs. Also I pass a __baseUrl parameter to the 
client in the same way that __useSocketIO.

But in the client it's necessary more work in order to close this issue. For 
instance the client starts to load:
/socket.io/socket.io.js
instead of
/otherdir/socket.io/socket.io.js
because this patch is generated from a external jar and I think is not 
configurable.

Any tips to follow?

Original issue reported on code.google.com by vruiz.ju...@gmail.com on 20 Jan 2011 at 5:15

Attachments:

GoogleCodeExporter commented 8 years ago
Could you upload a patch to our code review tool so we can make comments in 
context?

Instructions at http://www.waveprotocol.org/code/submitting-code

Original comment by ano...@google.com on 21 Jan 2011 at 12:50

GoogleCodeExporter commented 8 years ago
Thanks for the link.

Here a clone with my changes:
https://code.google.com/r/vruizjurado-wiab-integration/source/detail?r=572e6f893
f89898fb28239df577afb8ea7a99b02

(You can change the issue as enhancement better than defect) 

Original comment by vruiz.ju...@gmail.com on 21 Jan 2011 at 2:03

GoogleCodeExporter commented 8 years ago
Were you able to run the request_code_review.py script from the instructions 
above?

Original comment by hearn...@google.com on 27 Jan 2011 at 11:41

GoogleCodeExporter commented 8 years ago
Well I only followed the part "More complicated patches - making a clone" 
without the script. It's necessary also with clones?

Original comment by vruiz.ju...@gmail.com on 27 Jan 2011 at 11:49