search

blastbeng / spotisub

Spotify to subsonic Playlist Generator and Importer
MIT License
107 stars 6 forks source link

Feature Request: Add Streamrip to support Deezer #21

Open TheMBeat opened 2 months ago

blastbeng commented 2 months ago

Need more info.

TheMBeat commented 2 months ago

Streamrip can be used to download the missing songs. As Addition to the yt dl

blastbeng commented 2 months ago

I'll leave this issue open, at the moment i am not planning to implement new features

But I'll take it into consideration after Release 0.3.0

janaxhell commented 2 months ago

I'll add this info and personal experience here. I've been using https://github.com/youegraillot/lidarr-on-steroids for almost 2 years. It's a normal Lidarr with an added Deemix client in the form of plugin. It works, but it's not reliable at all. Many times it sends info that are not real or coherent to Lidarr, which skips the album it was going to download. What often happens is that the albums from Deezer appear as 0 minutes long or other similar nonsense. When manually force-downloaded, they do come in and are imported, but leaving this to Lidarr alone only makes the calendar fill with "Missing" albums. So in case you want to add both Lidarr and Deezer as a source for missing artists, consider adding them separately, with plain Lidarr just monitoring usenet/torrent and Streamrip monitoring Deezer.

blastbeng commented 2 months ago

I'll add this info and personal experience here. I've been using https://github.com/youegraillot/lidarr-on-steroids for almost 2 years. It's a normal Lidarr with an added Deemix client in the form of plugin. It works, but it's not reliable at all. Many times it sends info that are not real or coherent to Lidarr, which skips the album it was going to download. What often happens is that the albums from Deezer appear as 0 minutes long or other similar nonsense. When manually force-downloaded, they do come in and are imported, but leaving this to Lidarr alone only makes the calendar fill with "Missing" albums. So in case you want to add both Lidarr and Deezer as a source for missing artists, consider adding them separately, with plain Lidarr just monitoring usenet/torrent and Streamrip monitoring Deezer.

Thank you

I will certainly implement them separated.

By the way my idea about implementing spotdl was because not every album can be found by lidarr, my actual navidrome-spotisub-lidarr setup is as follown

Navidrome is configured to read music from: /music/

Lidarr import setup is configured to import songs to: /music/artist/artist - song - album.extension

If I enable SPOTDL extension in Spotisub, using this pattern as SPOTDL_FORMAT: /music/artist/artist - song - album.extension It will download songs in the same format as Lidarr, so when lidarr rescan this artist it will find the song and stops searching it.

This is the way I intended to implement it

janaxhell commented 2 months ago

Ok, but please allow the usage of Lidarr/Streamrip stand-alone at some point. I (and most likely a lot of people) will never add music taken from YT to my library, the quality is totally random.

blastbeng commented 2 months ago

Ok, but please allow the usage of Lidarr/Streamrip stand-alone at some point. I (and most likely a lot of people) will never add music taken from YT to my library, the quality is totally random.

We will see after release 0.3.0, and it will be separated for sure

Anyway I also don't like downloading from YouTube music, because as free user the quality is just 128.

I just use it when I don't find a better way to find a song

blastbeng commented 2 months ago

Ok, but please allow the usage of Lidarr/Streamrip stand-alone at some point. I (and most likely a lot of people) will never add music taken from YT to my library, the quality is totally random.

I mean, there are other priorities now before thinking of implementing something new

In my opinion, lidarr and spotdl integrations are just "addons" , they are not "priority features", so implementing Streamrip won't be a priority at all.

But like I said I'll leave this open just to keep track, and may be after Release 0.3.0 I will implement it

janaxhell commented 2 months ago

Do not worry, I'm beta testing and giving feedback, no hurry on anything.