blastbeng / spotisub

Spotify to subsonic Playlist Generator and Importer
MIT License
105 stars 6 forks source link

duplicate entries from different albums #29

Closed rantanlan closed 2 months ago

rantanlan commented 2 months ago

me gain, sorry ;)

with the db in place, now the artist recommendation seems to duplicate the songs regarding different albums. Tried the artist_recommendation with genesis and found the following playlist with 240 entries (limited to 100 via env)

Edit: same with different artists...

2024-09-18 00_03_20-Clipboard

blastbeng commented 2 months ago

me gain, sorry ;)

with the db in place, now the artist recommendation seems to duplicate the songs regarding different albums. Tried the artist_recommendation with genesis and found the following playlist with 240 entries (limited to 100 via env)

2024-09-18 00_03_20-Clipboard

Yep, the venv variable doesn't count duplicates

Anyway this is the way it is intendend to, at the actual state if you have a duplicate in your library it will be added x times for every album where it is present

Things will change in 0.2.1 hopefully.

rantanlan commented 2 months ago

alright I'll be patient... hope you don't mind reporting my findings.

blastbeng commented 2 months ago

your findings are useful :)

blastbeng commented 2 months ago

Version 0.2.1 has been released, it contains a better filtering on albums

Now you should have way less duplicates, but when the track's album isn't found inside subsonic database , spotisub will try to match this song to other tracks (with same name) from different albums

Just to confirm, I'll leave this issue open for now, since may be there is still some better improvement to implement