blastehh / AnotherULXSBanModule

Another implementation of SourceBans in to a ULX module
8 stars 10 forks source link

Sourcebans Group Overriding ULX Group #13

Closed Violat0r closed 8 years ago

Violat0r commented 8 years ago

In SourceBans, an admin is set to "Admin" as the server admin group with the server ticked inside Admin Server Access and in game is set to superadmin via ulx users.txt. The SBan module will override that superadmin in ulx's users.txt with "Admin" from sourcebans even though removeFromGroup is set to false and superadmin is one of the excludedGroups.

blastehh commented 8 years ago

Is it adding them to "Admin" group on the server?

On Sun, 19 Jun 2016 at 16:58 Violat0r notifications@github.com wrote:

In SourceBans, an admin is set to "Admin" as the server admin group with the server ticked inside Admin Server Access and in game is set to superadmin via ulx users.txt. The SBan module will override that superadmin in ulx's users.txt even though removeFromGroup is set to false and superadmin is one of the excludedGroups.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/blastehh/AnotherULXSBanModule/issues/13, or mute the thread https://github.com/notifications/unsubscribe/AH8GRSaUhSuSsZUJQyHq6iFn4KzMU_flks5qNWcbgaJpZM4I5MXm .

Violat0r commented 8 years ago

Yes, overriding superadmin or any other rank on the server with whatever rank they may have in sourcebans if that server is ticked in that person's server access.

blastehh commented 8 years ago

Yes, granting access will override anything... just untick the server on the website.

On Mon, 20 Jun 2016 at 09:56 Violat0r notifications@github.com wrote:

Yes, overriding superadmin or any other rank on the server with whatever rank they may have in sourcebans if that server is ticked in that person's server access.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/blastehh/AnotherULXSBanModule/issues/13#issuecomment-227085906, or mute the thread https://github.com/notifications/unsubscribe/AH8GRcrAkCJncxlSNpKN1Fy2uAH2Y3xaks5qNlWhgaJpZM4I5MXm .

Violat0r commented 8 years ago

Is there anyway to include or change the module so this doesn't happen?

blastehh commented 8 years ago

replace line 410 with "if (ULib.ucl.getUserRegisteredID(ply) == nil or ply:GetUserGroup() != group) or !excludedGroups[ply:GetUserGroup()] then" in anotherulxsbanmodule/lua/ulx/modules/sban.lua

On Mon, 20 Jun 2016 at 09:59 Violat0r notifications@github.com wrote:

Is there anyway to include or change the module so this doesn't happen?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/blastehh/AnotherULXSBanModule/issues/13#issuecomment-227086598, or mute the thread https://github.com/notifications/unsubscribe/AH8GRamLA3w4crVsSWUdNfkuEhcUQ9CGks5qNlZZgaJpZM4I5MXm .

Violat0r commented 8 years ago

Thanks, I will give that a try.

Violat0r commented 8 years ago

Sadly, that did not work.

Violat0r commented 8 years ago

Commenting out ulx.adduserid(ply, steamid, group) did not stop it from setting the rank from sourcebans, it must be doing it by other means.

Violat0r commented 8 years ago

Correction, commenting out ulx.adduserid(ply, steamid, group) does stop it but it seems like !excludedGroups[ply:GetUserGroup()] doesn't work.

blastehh commented 8 years ago

I used or instead of and: "if (ULib.ucl.getUserRegisteredID(ply) == nil or ply:GetUserGroup() != group) and !excludedGroups[ply:GetUserGroup()] then"

On Mon, 20 Jun 2016 at 10:20 Violat0r notifications@github.com wrote:

Commenting out ulx.adduserid(ply, steamid, group) did not stop it from setting the rank from sourcebans, it must be doing it by other means.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/blastehh/AnotherULXSBanModule/issues/13#issuecomment-227091325, or mute the thread https://github.com/notifications/unsubscribe/AH8GRYwTUrhz1spVE-2giI8h0a4ACzF5ks5qNltHgaJpZM4I5MXm .

blastehh commented 8 years ago

This will break the normal functionality of the addon though, use it at your own choice. If you want to change the group of an existing user, and their current group is in the excluded list, you'll have to do it manually.

On Mon, 20 Jun 2016 at 10:31 Matt blastuk@gmail.com wrote:

I used or instead of and: "if (ULib.ucl.getUserRegisteredID(ply) == nil or ply:GetUserGroup() != group) and !excludedGroups[ply:GetUserGroup()] then"

On Mon, 20 Jun 2016 at 10:20 Violat0r notifications@github.com wrote:

Commenting out ulx.adduserid(ply, steamid, group) did not stop it from setting the rank from sourcebans, it must be doing it by other means.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/blastehh/AnotherULXSBanModule/issues/13#issuecomment-227091325, or mute the thread https://github.com/notifications/unsubscribe/AH8GRYwTUrhz1spVE-2giI8h0a4ACzF5ks5qNltHgaJpZM4I5MXm .

Violat0r commented 8 years ago

I understand, that did do the trick to fit my communities needs, thank you for your help it is much appreciated.