search

blastrock / kakugo

Learn Japanese with Kakugo
GNU General Public License v3.0
166 stars 19 forks source link

Save vocab selection #48

Closed OldShatterham closed 4 years ago

OldShatterham commented 4 years ago

This pull request implements saving vocabulary selections and restoring them, akin to the save feature for kanji. In this implementation, the save functions use separate database tables and functions but the same interface and activities; therefore, SavedSelectionsActivity needs to be parameterized with the current mode (KANJI or WORD).

Note: This feature requires a new database version and database upgrade which I have not implemented. As such, it will currently not work and/or crash with an already existing database.

Closes #47

blastrock commented 4 years ago

Thank you for your two pull requests! Sorry for the long delay, I'll try to look at them soon and complete them (with french translation, and the database upgrade here).

Btw, no need to open issues corresponding to pull requests, this project doesn't follow a very uptight methodology ^^

blastrock commented 4 years ago

Thanks again for your contributions, I have rebased and merged them manually. I have just released 1.32 with them.

If you're ok with it, I'm going to add your name to the AUTHORS file in the contributors section. Shall I add "OldShatterham", or something else?

OldShatterham commented 4 years ago

Thank you very much! "OldShatterham" is fine ^^