Open seniorm0ment opened 4 years ago
jonycoo
commented
4 years ago please put this issue separate, to make it more easily referable. and update to title.
On the phrases, the words wrap on the screen when in my opinion the font size should change dynamically. For example currently it would say "my dog is wh ite" and break at the linebreak.
about the notification, I'll look what can do.
jonycoo
commented
4 years ago have now made the setting Interface to select weekday and Time. commit 24f82b2 in my own fork I'm not good at creating UI's in Android so please everyone feel free to suggest a better Layout.
blastrock
commented
4 years ago Yeah, I'd prefer separate issues. I'll still answer them here.
About your initial issue with the reminder, I'm not sure myself about what should be done. I think it shouldn't be too configurable, I would actually recommend practicing every day, and more than 10 items, as much as you can. I usually do it while commuting to work. I don't know either which test it should run, some people review their hiragana, some review their kanji, and even with that they have favorite tests.
I think this is a feature too complex to maintain for what it brings. I appreciate your efforts @jonycoo but I don't think I'll be merging that.
About the dark theme, I'm not a designer and I suck at choosing colors, that's why both themes are like that. I'm open to pull requests for that.
I'd appreciate a separate issue with a screen shot for the word wrapping issue.
As for the button sizes, the problem is that there is a lot to show on such a small screen. I recommend the single button mode to avoid these kind of issues.
Would like to suggest the ability to add a custom study reminder notification. My suggestion would be:
Time and Day Set an interval, for example once a day at xxx time or random time, once every 2 days, only on sundays and tuesdays, etc.
What test would you like the notification to send you to? You would set a default test type, and amount of questions, and when you click the notification it would take you into a mini quiz.
for example only 10 slides, then at the end it offers to keep going/into a full session or end daily session.
I am also suggesting making a dark theme that's colors are more towards material dark grey colors, the dark black is tough on my eyes personally.
On the phrases, the words wrap on the screen when in my opinion the font size should change dynamically. For example currently it would say "my dog is wh
ite" and break at the linebreak.
As well as maybe adjusting some of the button sizes to be more accessible.
Love the app however, appreciate your work! It's helping!