blaukc / pe

0 stars 0 forks source link

Class diagram for Logic component too small, hard to read #18

Open blaukc opened 2 months ago

blaukc commented 2 months ago

image.png

Not very visible, also there isnt the AddParentCommand, which i guess is why you put (partial) class diagram. But then if you're not including one command, it might be a better move to not include multiple commands so that the overall diagram is larger and more readable.

nus-se-bot commented 2 months ago

Team's Response

As explained in #3627, the user can just zoom in.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Fonts in diagrams of DG are too small

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


We can see that on page 6 of the DG, the font sizes in the (partial) class diagram is too small and also does not match the font size of the DG.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#3034] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Readers can zoom in to see the words if they need to, as most pdf readers allow for zooming in to a large extent. Therefore, fixing this issue is not as important as the work done in v1.4.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** It says here it can still be counted as a valid verylow cosmetic issue ![image.png](https://raw.githubusercontent.com/blaukc/pe/main/files/d2a54134-849a-495b-b346-af5a70b17d77.png)