search

blaukc / pe

0 stars 0 forks source link

Editing a tag removes the Parent tag #5

Open blaukc opened 2 months ago

blaukc commented 2 months ago

It would be expected that when adding a Parent using addp, the Parent tag would be permanent, however I am able to remove it when adding a child to the parent through the edit function:

image.png

After the child has been added, the parent tag disappears:

image.png

This is odd because when editing student tags, they do not disappear as shown in student 17:

image.png

nus-se-script commented 2 months ago

Team's Response

image.png As cautioned in the UG, under the 'Edit' portion of the 'Features' section, this behaviour is expected when using the edit command

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe the team may be misunderstanding what this bug is about, and has incorrectly linked it to another bug.

This bug is about the inconsistency in behaviour when editing tags for parent and students. When using the 'addp' command, a 'Parent' tag is set by default. When using the 'add' command, a 'Student' tag is set by default. When I edit a student, as shown in the images of the 'Original' bug, the 'Student' tag still remains there, and is not removed with all the other tags. This permanence makes sense to be there, you won't ever want to remove the tag of a student (and the same goes for a parent). However, when doing the same for a parent, the 'Parent' tag gets removed, even though the permanence of the 'Parent' tag is expected.

If the team believes that the 'Parent' tag should be removed when editing, then the same should go for the 'Student' tag.

In either case, there is a discrepancy in how the 'edit command works for tags on parents and students.