fix: substr reference to 9 chars

blauwfruit / PrestaShop-Order-Reference

PrestaShop module that customizes the order reference of an order.

24 stars 6 forks source link

Closed ghost closed 3 years ago

ghost commented 3 years ago

Please see #8

muyncky commented 3 years ago

@gett-thijssimonis considering this code:

if (!Validate::isReference($reference)) { ..

Why why does this check not prevent this issue?

ghost commented 3 years ago

isReference

This method does not check on length only if it match the regex /^[^<>;={}]*$/u