search

blavejr / OrganiseDesktop

Python script that cleans up a messy desktop
MIT License
91 stars 78 forks source link

Fixed tkinter and local imports #93

Open Sory-Noroc opened 3 years ago

Sory-Noroc commented 3 years ago

Hey! I am a new contributor, also new to Git, so I would appreciate if you would accept me in this project, and perhaps guide me as I develop/contribute to the app. :)

blavejr commented 3 years ago

Hey @Sory-Noroc welcome to the crew. :) I will take a look at your changes on Sunday evening and accept them if they are good, but I think they will be. thank you for helping out.

KokoseiJ commented 3 years ago

First of all, Thank you for your contribution.

if sys.version_info >= (3,) works already well in Python2. I doubt replacing it to try statement is a good idea. If it didn't work before, please tell us.

other than that- everything looks good. blavejr will accept it as soon as he checks the code.

blavejr commented 3 years ago

I agree with @KokoseiJ, the try might not be the best solution unless there is another reason.

Sory-Noroc commented 3 years ago

You might be right but I was getting an ImportError with the previous version from that tkMessageBox

Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr @.***> a scris:

I agree with @KokoseiJ https://github.com/KokoseiJ, the try might not be the best solution unless there is another reason.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blavejr/OrganiseDesktop/pull/93#issuecomment-799746341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ .

blavejr commented 3 years ago

You might be right but I was getting an ImportError with the previous version from that tkMessageBox Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr @.***> a scris: … I agree with @KokoseiJ https://github.com/KokoseiJ, the try might not be the best solution unless there is another reason. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ .

Hmmm are you running this on python3? because in that case we might be missing something

Sory-Noroc commented 3 years ago

Yes, ofc Im running it on python3

Lun, 15 mar. 2021, 23:05 Remigius Kalimba Jr @.***> a scris:

You might be right but I was getting an ImportError with the previous version from that tkMessageBox Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr @.***> a scris: … <#m8996315261215186939> I agree with @KokoseiJ https://github.com/KokoseiJ https://github.com/KokoseiJ, the try might not be the best solution unless there is another reason. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment) https://github.com/blavejr/OrganiseDesktop/pull/93#issuecomment-799746341>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ .

Hmmm are you running this on python3? because in that case we might be missing something

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blavejr/OrganiseDesktop/pull/93#issuecomment-799751789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHLJ5EMRT5GSNQ4OAVGG3TDZZCJANCNFSM4ZDR2UCQ .