search

blawar / ooot

GNU General Public License v2.0
698 stars 92 forks source link

Not able to change Z-Targetting option after creating a save file #340

Open Lehpumeh opened 1 year ago

Lehpumeh commented 1 year ago

Current Behavior

When you create a save file, you are permanently locked to the Z-Target option you have selected at the time.

What that means is if you open the game, go to options, set Z-Target to 'Hold' or keep it on 'Switch', then create a save file, that file will not be able to change it from Hold to Switch or Switch to Hold.

Expected Behavior

After making new file you should be able to switch the option at any time.

Steps to Reproduce

  1. Open game, choose your Z-Target option in the 'Options', and create a file and playthrough till you are able to Z-Target something.
  2. Z-Target someone to confirm the option you chose works
  3. Reset the game and try to change the option
  4. Enter the file and target anyone

Context (Environment)

I narrowed it down to being broken when the Save code was refactored with this commit https://github.com/blawar/ooot/commit/b64abaae30e703435f6fa0aa1651d068824aa79f.