search

blawar / ooot

GNU General Public License v2.0
698 stars 92 forks source link

Anju(chicken lady) is missing in kakariko as child #64

Closed numbypad closed 2 years ago

numbypad commented 2 years ago

New file, after beating deku tree I went to kak to collect the cuccos for the bottle, but Anju who usually stands right beside the fence you throw the chickens in is missing lol.

DaMarkov commented 2 years ago

An easy way to reproduce: Select the first save slot, choose 2: SPOT01 and walk up to the corner where Anju is supposed to be.

DaMarkov commented 2 years ago

Relevant code is in EnNiwLady_Init()

this->objectOsAnimeIndex = Object_GetIndex(&globalCtx->objectCtx, OBJECT_OS_ANIME);
    if ((this->objectOsAnimeIndex < 0) || (this->objectAneIndex < 0)) {
        Actor_Kill(thisx);
        return;
    }

Object_GetIndex returns a s32 when cast to s8 objectOsAnimeIndex becomes negative and the actor get killed.

PR #69 fixes this issue.

Zero3K commented 2 years ago

PR #69 has been merged so this issue is now being closed.