search

blaxxun-boop / Backpacks

3 stars 4 forks source link

Reopen: Missing Recipes Solved #54

Open GracefulUni opened 1 month ago

GracefulUni commented 1 month ago

Hi Blaxxun, Based on my previous issue that you closed, I finally figured out the cause of the missing recipes disappearing compared to the rest of my backpacks that are not gone. Half of my backpacks do NOT have an upgrade recipe, while the ones in image do have a upgrade recipe, I added upgrade recipes to one of the backpacks and the bug happened where all my other recipes disappeared, but the one that I recently added an upgrade recipe to it that one didnt disappear from the crafting list.

TLDR, if the backpacks do not have an upgrade recipe there is a chance that the recipe will disappear from the crafting bench, I tested this twice already.

BETLOG commented 1 week ago

I just compiled a bunch of packs with zero upgradeability, and had no issues.

WIP, but seems to work ok:

Backpacks_betlog.zip

FYI: I did notice that things can get weird and you might need to re-aquire ingredients before the recipe appears. (as mentioned in another issue here) I have also started destroying all prior versions that exist as ingame objects (get an obliterator), partly to reduce confusion, and partly to make sure there isnt a cache somewhere tripping over itself. Dont put comments at end of yaml lines. Use the configurationmanager yaml editor that is available when you toggle custom yaml on and a valid file is detected, just to check if the syntax is ok. You can still edit the yaml externally and it autoupdates when you save.

blaxxun-boop commented 1 week ago

@BETLOG Please note that "no license" on GitHub means, you aren't allowed to touch the code at all.

BETLOG commented 1 week ago

@BETLOG Please note that "no license" on GitHub means, you aren't allowed to touch the code at all.

I'm looking for the backpacks licence to use as a guide, but i cant see any... is a line in the yaml saying # LICENSE : public domain enough? I assume thats the code you refer to.

BETLOG commented 1 week ago

lol, after saying it works fine and implying more care needed, AND after experiencing this numerous months ago last time I used backpacks (so i should know better already)... i just went to poke around in my WIP backpacks that were working fine for hours while i broke and fixed them repeatedly last night, which haven't been changed since then except to add # LICENSE : public domain to the first line....and now they were completely absent from the workbench. What ended up working is to reset (set off) external yaml in configurationmanager, and then re-enable it, check my yaml was detected, loaded and syntax valid, and hey presto the backpacks list on the workbench again. Yeah, this is a longtime recurring bug thats probably going to be hard to duplicate.

[edit] Unlikely, but maybe being connected to a dedicated server, but not having the mod or the config on said server; rather only on the client, is part of the problem.

[edit] Also I noticed that the symlink i was using for my yml has been overwritten with an actual file, so evidently something doesnt respect linux filesystems. So you can see the relativity of the file/link: file: /media/user/steamdata/TOOLS/valheim/mods/customData/backpacks/Backpacks_betlog.yml symlink: /media/user/steamdata/.steam/steam/steamapps/common/Valheim/BepInEx/config/Backpacks_betlog.yml It seems partially relevant because it would have desynchronised what I was editing vs what the game was loading. Confirmed: clicking reset external yaml in configurationamager > Backpacks 1.3.4 results in the symlink being replaced with a file. It reads the link just fine, but it stomps it like a caveperson when it arbitrarily updates its modified timestamp.