search

blaze / datashape

Language defining a data description protocol
BSD 2-Clause "Simplified" License
183 stars 65 forks source link

ENH: Adds record literals #186

Closed llllllllll closed 8 years ago

llllllllll commented 8 years ago

Implements the record literal syntax we discussed at strata

@cpcloud @jcrist

llllllllll commented 8 years ago

Any other comments? Do you think that this is actually something we want in the library? I was working with some programatic dshapes today and it was pretty rough without this; however, I could understand not wanting to confuse people.

cpcloud commented 8 years ago

I'd mark this as an experimental feature then merge. Also add a big note that this particular syntax is subject change and possibly even removal

llllllllll commented 8 years ago

Where would I mark this, just in the whatsnew?

llllllllll commented 8 years ago

Also, one thought that I had when talking to scott was that this might be better with just a single : to look more like the dshape string.

cpcloud commented 8 years ago

I'm okay with either syntax, but not both.

cpcloud commented 8 years ago

Yep mark in what's new

llllllllll commented 8 years ago

Okay, I think I prefer the single then since it is closer to the dshape sytax. I will make that change and update the whatsnew.

cpcloud commented 8 years ago

Just merged a PR that probably conflicted with this one

llllllllll commented 8 years ago

kk, I will rebase. I don't think the cleanups will confilict in a difficult way.