search

blaze / datashape

Language defining a data description protocol
BSD 2-Clause "Simplified" License
183 stars 65 forks source link

Fix unicode field names (again) #200

Closed cpcloud closed 8 years ago

cpcloud commented 8 years ago

@llllllllll can you give this a quick review?

llllllllll commented 8 years ago

Is there a reason that we want to avoid having mixed type keys? In python2 string and unicode hash the same so our getitem will still work. I don't mind promoting all the keys, just wondering.

cpcloud commented 8 years ago

Pandas 0.17.x is now enforcing that columns all have the same type in their test functions and we use them all over the place so this is really just to prevent further headaches down the road

llllllllll commented 8 years ago

Ah. Looks good to me.

llllllllll commented 8 years ago

edit: nvm