Refactor promote to correctly handle `string` and `?string`.

blaze / datashape

Language defining a data description protocol

BSD 2-Clause "Simplified" License

183 stars 65 forks source link

Refactor promote to correctly handle `string` and `?string`. #213

Closed kwmsmith closed 8 years ago

kwmsmith commented 8 years ago

Also test the same logic for datashape.datetime_.

kwmsmith commented 8 years ago

@llllllllll thoughts? This partially addresses blaze/blaze#1241. We've hit this multiple times when joining two datasets on string and ?string columns; will be merging soon.

llllllllll commented 8 years ago

lgtm, the tests look really good!