blaze / datashape

Language defining a data description protocol
BSD 2-Clause "Simplified" License
183 stars 65 forks source link

Tests fail using Python 3.6 #221

Closed ilanschnell closed 7 years ago

ilanschnell commented 7 years ago

Running datashape 0.5.2 against Python 3.6rc2 (64-bit Linux). I get:

_______________________ [doctest] datashape.internal_utils.groupby _______________________
Expected:
    {3: ['Bob', 'Dan'], 5: ['Alice', 'Edith', 'Frank'], 7: ['Charlie']}
Got:
    {5: ['Alice', 'Edith', 'Frank'], 3: ['Bob', 'Dan'], 7: ['Charlie']}
skrah commented 7 years ago

@ilanschnell I just fixed it in master. Do you need the fix in 0.5.2, too?

ilanschnell commented 7 years ago

Thanks for fixing it. How do you fix it in 0.5.2 retrospectively? I would suggest to release a new version which includes the fix.

skrah commented 7 years ago

You're right, of course there is a released tarball already for 0.5.2 (and also for 0.5.3). I guess the new version will be 0.5.4.

ilanschnell commented 7 years ago

So when are you planning to tag 0.5.4?

skrah commented 7 years ago

I just tagged and pushed the release, Travis-CI looks good with Python 3.6.

ilanschnell commented 7 years ago

Thanks, I'll give it a try.