search

blaze / datashape

Language defining a data description protocol
BSD 2-Clause "Simplified" License
183 stars 65 forks source link

Incorrect datetime discovery #91

Closed mrocklin closed 9 years ago

mrocklin commented 10 years ago 
In [5]: discover("31-DEC-99 12.00.00.000000000 AM")
Out[5]: Date()

Should be datetime

cpcloud commented 9 years ago

This is now returning string

In [14]: discover("31-DEC-99 12.00.00.000000000")
Out[14]: ctype("string")
cpcloud commented 9 years ago

I don't think . is a valid time separator.

mrocklin commented 9 years ago

Personally I'm fine if our datetime detection doesn't work on every possible format.

cpcloud commented 9 years ago

Okay. I'll add a test for this and close the issue in the PR